|(8 intermediate revisions by 3 users not shown)|
=== Current State ===
An initial implementation is now in SVN. Limitations:
* Allows a single <style> element in the document. Doesn't allow external stylesheets, doesn't allow more than one <style> element.
: (Or rather it ignores all but one of the <style> elements, possibly changing which one it respects based on which was most recently re-read.)
* No editing interface other than the XML editor.
: There are a number of aspects of editing:
** The most basic level: allow editing using the XML editor . ( See Update section below.)
editor (). .
** Editing a stylesheet.
** Specifying what classes each object belongs to.
* Doesn't respect media restrictions (e.g. ignores "this rule applies only to non-visual media" directives, and doesn't allow having one style for print and another style for on-screen).
* <tt>@font-face</tt> hints are ignored.
Doesn't handle any other at-rules (<tt>@media</tt>, <tt>@import</tt>, @page, ... ).
* , . . . .
==== An incomplete list of work needed: ====
Ensure that this single stylesheet is updated whenever any of the <tt>
Updated August 2017
Inkscape supports a single <style> element in the document. If there is more than one style element, Inkscape will pick one to use.
@import is supported as of 0.93 (read-only). other @-rules are not supported.
There is a simple style editor (Object -> Style dialog). Selectors can be added/deleted.
Work Needed (incomplete list)
- As of 0.93, libcroco supports multiple style sheets in a document. Inkscape needs to change how style sheet are handled to make use of this. Currently style sheet handling is tied to style elements. This needs to be changed so that style sheet handling is tied to the document so that all style sheets are evaluated at the same time.
- Check that all "shorthand properties" are supported.
- Improve the usability of the Style dialog so that properties can be moved back and forth between style attributes and style elements.
THE REST IS OUT-OF-DATE
Updating for changes to <style> content
State so far: Every keystroke in the XML Editor in the content of the <style> element gets sp_style_elem_read_content to be re-read.
One can force an object to get the revised stylesheet info…e.g., by <Up> <Down> (forcing an update) then deleting its style attribute.
So, one change is that we shouldn't be so keen to put things in the style attribute.
Currently, the stylesheet info gets merged into SPStyle, and set the style attribute to contain everything in SPStyle (and clear any styling attributes like fill=...).
One existing problem with this behaviour (other than how it interacts with stylesheets) is that we discard any style properties we don't know about.
Instead we should remember the content of the style attribute and only replace the properties we've changed, adding only as necessary.
One implementation would be to keep SPStyle but indicate which properties came from where, and hence which ones need to be written to the style attribute and which ones don't.
Apart from not writing if src==stylesheet, we can also avoid writing if src==attribute: i.e. don't gratuitously break SVG Tiny conformance of a document (or more generally break compatibility with implementations that don't honour CSS style attributes).
Not to say that we can't choose to use the style attribute for properties that the user changes during an inkscape session, but currently we change from attributes to style=... even for shapes that the user just changes the position of without changing any styling stuff.
Why can't we use libcroco-0.6's existing libxml interface to cr-sel-eng.c ?
Some CSS selectors (http://www.w3.org/TR/REC-CSS2/selector.html) can express "is preceded by X" or "is a descendent of X" (where X can itself be similarly constrained recursively), so we'd pretty much need to maintain the entire document in libxml form if we want to use libcroco for CSS selectors.
Suppose we want to find the style of node N. We pass libcroco a stylesheet and ask it what rules apply to N.
If the stylesheet says "nodes that are preceded by a node that is preceded by a node that's a descendent of (... etc. ...) have red stroking" then libcroco needs to be able to navigate through the tree.
So we can't pass libcroco just a libxml version of node N, we need to fill in its parent and sibling links, providing a libxml node for a significant proportion of all nodes in the tree.
(Short of using hardware watchpoints to check access to the sibling/parent links and supply them lazily.)
Implementing External Stylesheets…
External stylesheets are arguably easier to implement than internal ones: the reference to the stylesheet comes right at the beginning of the xml file before even the top-level <svg> element, so we already know all the styling stuff for <svg> as soon as we reach it. Editing may also be a bit easier, in that external stylesheets usually exist for sharing styles across many documents, so there's less expectation of being able to edit the stylesheet itself.
The work of actually parsing the stylesheet once it's in memory is already done: see src/sp-style-elem.cpp:sp_style_elem_read_content.
So for read-only support of a single external stylesheet, it may well be just a matter of looking at how we can get XML processing instructions from libxml2 (please add a reference to the relevant documentation or code here once you've looked it up, anyone), and parse the pseudo-xml-attributes (see http://www.w3.org/TR/xml-stylesheet/; note that these aren't real xml attributes that libxml2 handles, so we do the parsing ourselves — or pass the string to a separate libxml2 instance/session/parser).
Then get the CSS from the specified URI (presumably using the same gnome vfs stuff that we currently use for accepting URIs from the command line…though we could use libcurl instead: man curl, and see the --libcurl option for producing example code).
Then proceed as sp-style-elem.cpp:sp_style_elem_read_content does (presumably splitting off most of that function into a new function that takes the string as argument).
Initially, we would support only a single stylesheet, as libcroco currently doesn't support multiple stylesheets.
If you don't want to change libcroco, then it suffices to concatenate all the stylesheets together; the only thing you lose with that approach is that any parsing errors won't have the right line number, but I believe it gives completely correct results in absence of errors in any of the stylesheets.
The xml-stylesheet spec says that multiple external stylesheets interact the same way as in HTML; the relevant part of the HTML spec is http://www.w3.org/TR/html4/present/styles.html#h-14.3.