Refactoring projects - Revision history

Tavmjong at 07:16, 15 April 2023

2023-04-15T07:16:29Z

← Older revision		Revision as of 07:16, 15 April 2023
Line 7:		Line 7:

	See [[Refactoring plan]] for guidelines on how to refactor.		See [[Refactoring plan]] for guidelines on how to refactor.

			'''''Attention: Some of these suggestions might not make sense''' or have better solutions. For example instead of moving some unused function to a different file, you should remove it. Apply the [[Refactoring plan#Principles\|principles]] of adding unit tests and adding documentation (doxygen comments).''

	= Little Projects =		= Little Projects =

	'''''Attention: Some of these suggestions might not make sense''' or have better solutions. For example instead of moving some unused function to a different file, you should remove it. Apply the [[Refactoring plan#Principles\|principles]] of adding unit tests and adding documentation (doxygen comments).''

	* <strike>Derive SPStar from SPShape (not SPPolygon), update 'object/README'.</strike>		* <strike>Derive SPStar from SPShape (not SPPolygon), update 'object/README'.</strike>

Tavmjong: /* Super Large Projects */

2023-04-15T07:13:14Z

Super Large Projects

← Older revision		Revision as of 07:13, 15 April 2023
Line 80:		Line 80:
	= Super Large Projects =		= Super Large Projects =

	* <~~stroke~~>Convert verbs to Gio::Action's.<strike> Done		* <strike>Convert verbs to Gio::Action's.<strike> Done
	* Convert GUI to XML files. (Long term.)		* Convert GUI to XML files. (Long term.)
	* <strike>Invert 'y' coordinate system to match SVG. (Look at previous patch... link?)</strike>		* <strike>Invert 'y' coordinate system to match SVG. (Look at previous patch... link?)</strike>

Tavmjong: /* Little Projects */

2023-04-15T07:12:29Z

Little Projects

← Older revision		Revision as of 07:12, 15 April 2023
Line 42:		Line 42:
	* Move spw_label and spw_hbox to stroke-style.cpp (only place they are used) and rename (or maybe don't use). Give better names to sp_search_xxxx and move to ui/?.		* Move spw_label and spw_hbox to stroke-style.cpp (only place they are used) and rename (or maybe don't use). Give better names to sp_search_xxxx and move to ui/?.
	* Remove Desktop::setToolboxAdjustmentValue() (used mostly by spray tool, one use each in calligraphic and eraser tools).		* Remove Desktop::setToolboxAdjustmentValue() (used mostly by spray tool, one use each in calligraphic and eraser tools).
			* Convert ColorSlider to be derived from Gtk::DrawingArea rather than a GdkWindow.

	= Medium Projects =		= Medium Projects =

Tavmjong at 13:11, 12 March 2023

2023-03-12T13:11:24Z

← Older revision		Revision as of 13:11, 12 March 2023
Line 31:		Line 31:
	* Move functionality of src/line-geometry.h/.cpp into lib2geom or elsewhere.		* Move functionality of src/line-geometry.h/.cpp into lib2geom or elsewhere.
	* <strike>Remove deprecated GDK_POINTER_MOTION_HINT_MASK (motion events are compressed since Gdk 3.8).</strike> [https://gitlab.com/inkscape/inkscape/-/commit/28587f2d2fb0c83bd12c8364994332dea100143b Removed]		* <strike>Remove deprecated GDK_POINTER_MOTION_HINT_MASK (motion events are compressed since Gdk 3.8).</strike> [https://gitlab.com/inkscape/inkscape/-/commit/28587f2d2fb0c83bd12c8364994332dea100143b Removed]
	* Turn DrawAnchor into a proper class (or figure out how to get rid of it all together)~~. Update, there is a class SPDrawAnchor and a structure SPDrawAnchor~~.		* Turn DrawAnchor into a proper class (or figure out how to get rid of it all together).
	* Clean up constructors and signals in selcue.cpp.		* Clean up constructors and signals in selcue.cpp.
	* <strike>Remove need to write out and read back in a PNG file with createBitmapImage().</strike> [https://gitlab.com/inkscape/inkscape/-/commit/09f2b4a77169d172b81a30b8c638124aeac77e8a Done]		* <strike>Remove need to write out and read back in a PNG file with createBitmapImage().</strike> [https://gitlab.com/inkscape/inkscape/-/commit/09f2b4a77169d172b81a30b8c638124aeac77e8a Done]
Line 48:		Line 48:
	* Move most files in 'src' to subdirectories, add ''README'' for each directory with description of contents. (Tav)		* Move most files in 'src' to subdirectories, add ''README'' for each directory with description of contents. (Tav)
	* <strike>In toolbars, use ''dataKludge'' or ''data'' or ''tbl'' or ''holder'' ... but not all four!</strike> (Side benefit of C++ify toolbars.) (Alex)		* <strike>In toolbars, use ''dataKludge'' or ''data'' or ''tbl'' or ''holder'' ... but not all four!</strike> (Side benefit of C++ify toolbars.) (Alex)
	* <strike>Remove InkAction class. Normal GTK button actions should be able to handle SVG icons... no need for derived class.<strike> (Alex) Done		* <strike>Remove InkAction class. Normal GTK button actions should be able to handle SVG icons... no need for derived class.</strike> (Alex) Done
	* Make data members private in SPI::Base and derived class. Add set() function. Default to SP_STYLE_UNSET in constructor, setting to SP_STYLE_SRC_PROP in set(). (Tav)		* Make data members private in SPI::Base and derived class. Add set() function. Default to SP_STYLE_UNSET in constructor, setting to SP_STYLE_SRC_PROP in set(). (Tav)
	* Sort out URL/file handling. See [[URIs and Filenames]].		* Sort out URL/file handling. See [[URIs and Filenames]].

Tavmjong: /* Little Projects */

2023-03-06T12:37:33Z

Little Projects

← Older revision		Revision as of 12:37, 6 March 2023
Line 31:		Line 31:
	* Move functionality of src/line-geometry.h/.cpp into lib2geom or elsewhere.		* Move functionality of src/line-geometry.h/.cpp into lib2geom or elsewhere.
	* <strike>Remove deprecated GDK_POINTER_MOTION_HINT_MASK (motion events are compressed since Gdk 3.8).</strike> [https://gitlab.com/inkscape/inkscape/-/commit/28587f2d2fb0c83bd12c8364994332dea100143b Removed]		* <strike>Remove deprecated GDK_POINTER_MOTION_HINT_MASK (motion events are compressed since Gdk 3.8).</strike> [https://gitlab.com/inkscape/inkscape/-/commit/28587f2d2fb0c83bd12c8364994332dea100143b Removed]
	* Turn DrawAnchor into a proper class (or figure out how to get rid of it all together).		* Turn DrawAnchor into a proper class (or figure out how to get rid of it all together). Update, there is a class SPDrawAnchor and a structure SPDrawAnchor.
	* Clean up constructors and signals in selcue.cpp.		* Clean up constructors and signals in selcue.cpp.
	* <strike>Remove need to write out and read back in a PNG file with createBitmapImage().</strike> [https://gitlab.com/inkscape/inkscape/-/commit/09f2b4a77169d172b81a30b8c638124aeac77e8a Done]		* <strike>Remove need to write out and read back in a PNG file with createBitmapImage().</strike> [https://gitlab.com/inkscape/inkscape/-/commit/09f2b4a77169d172b81a30b8c638124aeac77e8a Done]

Tavmjong: /* Medium Projects */

2023-03-06T12:30:32Z

Medium Projects

← Older revision		Revision as of 12:30, 6 March 2023
Line 48:		Line 48:
	* Move most files in 'src' to subdirectories, add ''README'' for each directory with description of contents. (Tav)		* Move most files in 'src' to subdirectories, add ''README'' for each directory with description of contents. (Tav)
	* <strike>In toolbars, use ''dataKludge'' or ''data'' or ''tbl'' or ''holder'' ... but not all four!</strike> (Side benefit of C++ify toolbars.) (Alex)		* <strike>In toolbars, use ''dataKludge'' or ''data'' or ''tbl'' or ''holder'' ... but not all four!</strike> (Side benefit of C++ify toolbars.) (Alex)
	* Remove InkAction class. Normal GTK button actions should be able to handle SVG icons... no need for derived class. (Alex)		* <strike>Remove InkAction class. Normal GTK button actions should be able to handle SVG icons... no need for derived class.<strike> (Alex) Done
	* Make data members private in SPI::Base and derived class. Add set() function. Default to SP_STYLE_UNSET in constructor, setting to SP_STYLE_SRC_PROP in set(). (Tav)		* Make data members private in SPI::Base and derived class. Add set() function. Default to SP_STYLE_UNSET in constructor, setting to SP_STYLE_SRC_PROP in set(). (Tav)
	* Sort out URL/file handling. See [[URIs and Filenames]].		* Sort out URL/file handling. See [[URIs and Filenames]].
	* Find all the ways we output error/status messages to users (this does not include developer focused error messages that use std::cerr). Pick one and use it everywhere. The goal should be to be able to build Inkscape without a GUI but if the GUI is used, the user will see the messages on the desktop.		* Find all the ways we output error/status messages to users (this does not include developer focused error messages that use std::cerr). Pick one and use it everywhere. The goal should be to be able to build Inkscape without a GUI but if the GUI is used, the user will see the messages on the desktop.
	* Look at Inkscape::URIReference and derived classes to see if they can't be simplified/templated/etc.		* Look at Inkscape::URIReference and derived classes to see if they can't be simplified/templated/etc.
	* Make sp_repr_set_svg_double etc. member functions of Inkscape::XML::Node. [sp_repr_set_svg_double() -> setAttributeSvgDouble()].		* <strike>Make sp_repr_set_svg_double etc. member functions of Inkscape::XML::Node. [sp_repr_set_svg_double() -> setAttributeSvgDouble()].</strike>
	* Redo Save/Export separating Lossless vs Lossy formats. Create one path for all Exports that share processing so that all options (that make sense) are available to all output formats.		* Redo Save/Export separating Lossless vs Lossy formats. Create one path for all Exports that share processing so that all options (that make sense) are available to all output formats.
	* Refactor toolbase and derived classes. The conversion from C to C++ seems to be only partially done.		* Refactor toolbase and derived classes. The conversion from C to C++ seems to be only partially done.

Tavmjong: /* Super Large Projects */

2023-03-06T12:26:43Z

Super Large Projects

← Older revision		Revision as of 12:26, 6 March 2023
Line 79:		Line 79:
	= Super Large Projects =		= Super Large Projects =

	* Convert verbs to Gio::Action's.		* <stroke>Convert verbs to Gio::Action's.<strike> Done
	* Convert GUI to XML files. (Long term.)		* Convert GUI to XML files. (Long term.)
	* <strike>Invert 'y' coordinate system to match SVG. (Look at previous patch... link?)</strike>		* <strike>Invert 'y' coordinate system to match SVG. (Look at previous patch... link?)</strike>

Tavmjong: /* Large Projects */

2023-03-06T12:25:36Z

Large Projects

← Older revision		Revision as of 12:25, 6 March 2023
Line 71:		Line 71:

	* <strike>C++ify toolbars.</strike> (Alex) Multiple commits.		* <strike>C++ify toolbars.</strike> (Alex) Multiple commits.
	* Convert all GtkActions's and Gtk::Action's to Gio::Action's. See [[GtkAction migration]] (Alex)		* <strike>Convert all GtkActions's and Gtk::Action's to Gio::Action's.</strike> See [[GtkAction migration]] (Alex) Done
	* Add a one or two line description of what each file contains at the top of the file if it is missing. (Everyone)		* Add a one or two line description of what each file contains at the top of the file if it is missing. (Everyone)
	* Remove livarot, moving any needed functionality into lib2geom or other files.		* Remove livarot, moving any needed functionality into lib2geom or other files.

Tavmjong: /* Medium Projects */

2021-09-02T08:37:29Z

Medium Projects

← Older revision		Revision as of 08:37, 2 September 2021
Line 66:		Line 66:
	* Merge old knot code with "new" control-point code.		* Merge old knot code with "new" control-point code.
	* Figure out why the cursor SVG file is reloaded when a drawing file is reverted and stop it from happening.		* Figure out why the cursor SVG file is reloaded when a drawing file is reverted and stop it from happening.
			*Remove GUI dependencies in SPObjects (SPNamedView and Grid for example).

	= Large Projects =		= Large Projects =

Tavmjong: /* Little Projects */

2021-08-29T14:01:55Z

Little Projects

← Older revision		Revision as of 14:01, 29 August 2021
Line 40:		Line 40:
	* Removed desktop dependency from hiding/unhiding, locking/unlocking objects and layers.		* Removed desktop dependency from hiding/unhiding, locking/unlocking objects and layers.
	* Remove widgets/widget-sizes.h Most of this should be replaced by CSS.		* Remove widgets/widget-sizes.h Most of this should be replaced by CSS.
	*Move spw_label and spw_hbox to stroke-style.cpp (only place they are used) and rename (or maybe don't use). Give better names to sp_search_xxxx and move to ui/?.		* Move spw_label and spw_hbox to stroke-style.cpp (only place they are used) and rename (or maybe don't use). Give better names to sp_search_xxxx and move to ui/?.
			* Remove Desktop::setToolboxAdjustmentValue() (used mostly by spray tool, one use each in calligraphic and eraser tools).

	= Medium Projects =		= Medium Projects =