Object Ownership - Revision history

Tavmjong: /* Life Cycle */

2021-10-04T15:55:59Z

Life Cycle

← Older revision		Revision as of 15:55, 4 October 2021
Line 92:		Line 92:
	Selection::Selection		Selection::Selection
	InkscapeWindow::InkscapeWindow: Entrance		InkscapeWindow::InkscapeWindow: Entrance
	SPDesktopWidget::SPDesktopWidget(): Entrance		SPDesktopWidget::SPDesktopWidget(): Entrance
	SPDesktopWidget::SPDesktopWidget(): Exit		SPDesktopWidget::SPDesktopWidget(): Exit
	SPDesktop::SPDesktop: entrance		SPDesktop::SPDesktop: entrance
	Selection::Selection		Selection::Selection
	SPDesktop::SPDesktop: exit		SPDesktop::SPDesktop: exit
	SPDesktop::init(): entrance		SPDesktop::init(): entrance
	SPDesktop::init(): Exit		SPDesktop::init(): Exit
	SPDesktopWidget::on_realize: Entrance		SPDesktopWidget::on_realize: Entrance
	SPDesktopWidget::on_realize: Exit		SPDesktopWidget::on_realize: Exit
	InkscapeWindow::InkscapeWindow: Exit		InkscapeWindow::InkscapeWindow: Exit

Line 108:		Line 108:
	SPDocument::SPDocument(): Exit		SPDocument::SPDocument(): Exit
	InkscapeWindow::InkscapeWindow: Entrance		InkscapeWindow::InkscapeWindow: Entrance
	SPDesktopWidget::SPDesktopWidget(): Entrance		SPDesktopWidget::SPDesktopWidget(): Entrance
	SPDesktopWidget::SPDesktopWidget(): Exit		SPDesktopWidget::SPDesktopWidget(): Exit
	SPDesktop::SPDesktop: entrance		SPDesktop::SPDesktop: entrance
	Selection::Selection		Selection::Selection
	SPDesktop::SPDesktop: exit		SPDesktop::SPDesktop: exit
	SPDesktop::init(): entrance		SPDesktop::init(): entrance
	Selection::Selection		Selection::Selection
	SPDesktop::init(): Exit		SPDesktop::init(): Exit
	SPDesktopWidget::on_realize: Entrance		SPDesktopWidget::on_realize: Entrance
	SPDesktopWidget::on_realize: Exit		SPDesktopWidget::on_realize: Exit
	InkscapeWindow::InkscapeWindow: Exit		InkscapeWindow::InkscapeWindow: Exit

Line 123:		Line 123:

	InkscapeWindow::InkscapeWindow: Entrance		InkscapeWindow::InkscapeWindow: Entrance
	SPDesktopWidget::SPDesktopWidget(): Entrance		SPDesktopWidget::SPDesktopWidget(): Entrance
	SPDesktopWidget::SPDesktopWidget(): Exit		SPDesktopWidget::SPDesktopWidget(): Exit
	SPDesktop::SPDesktop: entrance		SPDesktop::SPDesktop: entrance
	Selection::Selection		Selection::Selection
	SPDesktop::SPDesktop: exit		SPDesktop::SPDesktop: exit
	SPDesktop::init(): entrance		SPDesktop::init(): entrance
	SPDesktop::init(): Exit		SPDesktop::init(): Exit
	SPDesktopWidget::on_realize: Entrance		SPDesktopWidget::on_realize: Entrance
	SPDesktopWidget::on_realize: Exit		SPDesktopWidget::on_realize: Exit
	InkscapeWindow::InkscapeWindow: Exit		InkscapeWindow::InkscapeWindow: Exit

Line 138:		Line 138:
	InkscapeWindow::~InkscapeWindow: Exit		InkscapeWindow::~InkscapeWindow: Exit
	SPDesktopWidget::on_unrealize: Entrance		SPDesktopWidget::on_unrealize: Entrance
	SPDesktop::destroy()		SPDesktop::destroy()
	Selection::~Selection(): Entrance		Selection::~Selection(): Entrance
	Selection::~Selection(): Exit		Selection::~Selection(): Exit
	SPDesktop::destroy(): Exit		SPDesktop::destroy(): Exit
	SPDesktopWidget::on_unrealize: Exit		SPDesktopWidget::on_unrealize: Exit
	SPDesktopWidget::~SPDesktopWidget		SPDesktopWidget::~SPDesktopWidget
Line 151:		Line 151:
	InkscapeWindow::~InkscapeWindow: Exit		InkscapeWindow::~InkscapeWindow: Exit
	SPDesktopWidget::on_unrealize: Entrance		SPDesktopWidget::on_unrealize: Entrance
	SPDesktop::destroy()		SPDesktop::destroy()
	Selection::~Selection(): Entrance		Selection::~Selection(): Entrance
	Selection::~Selection(): Exit		Selection::~Selection(): Exit
	SPDesktop::destroy(): Exit		SPDesktop::destroy(): Exit
	SPDesktopWidget::on_unrealize: Exit		SPDesktopWidget::on_unrealize: Exit
	SPDesktopWidget::~SPDesktopWidget		SPDesktopWidget::~SPDesktopWidget
Line 166:		Line 166:
	InkscapeWindow::~InkscapeWindow: Exit		InkscapeWindow::~InkscapeWindow: Exit
	SPDesktopWidget::on_unrealize: Entrance		SPDesktopWidget::on_unrealize: Entrance
	SPDesktop::destroy()		SPDesktop::destroy()
	Selection::~Selection(): Entrance		Selection::~Selection(): Entrance
	Selection::~Selection(): Exit		Selection::~Selection(): Exit
	SPDesktop::destroy(): Exit		SPDesktop::destroy(): Exit
	SPDesktopWidget::on_unrealize: Exit		SPDesktopWidget::on_unrealize: Exit
	SPDesktopWidget::~SPDesktopWidget		SPDesktopWidget::~SPDesktopWidget

Tavmjong: Add life cycle info.

2021-10-04T11:47:47Z

Add life cycle info.

← Older revision		Revision as of 11:47, 4 October 2021
Line 79:		Line 79:
	==== Selections ====		==== Selections ====
	Selections should be owned by InkscapeWindow with an additional selection owned by InkscapeApplication for use with the GUI.		Selections should be owned by InkscapeWindow with an additional selection owned by InkscapeApplication for use with the GUI.

			==== Life Cycle ====
			<pre>
			OPEN INKSCAPE

			InkscapeApplication::InkscapeApplication: Entrance
			InkscapeApplication::InkscapeApplication: Exit
			Application::Application: Entrance
			Application::Application: Exit
			SPDocument::SPDocument(): Entrance
			SPDocument::SPDocument(): Exit
			Selection::Selection
			InkscapeWindow::InkscapeWindow: Entrance
			SPDesktopWidget::SPDesktopWidget(): Entrance
			SPDesktopWidget::SPDesktopWidget(): Exit
			SPDesktop::SPDesktop: entrance
			Selection::Selection
			SPDesktop::SPDesktop: exit
			SPDesktop::init(): entrance
			SPDesktop::init(): Exit
			SPDesktopWidget::on_realize: Entrance
			SPDesktopWidget::on_realize: Exit
			InkscapeWindow::InkscapeWindow: Exit

			ADD NEW DOCUMENT

			SPDocument::SPDocument(): Entrance
			SPDocument::SPDocument(): Exit
			InkscapeWindow::InkscapeWindow: Entrance
			SPDesktopWidget::SPDesktopWidget(): Entrance
			SPDesktopWidget::SPDesktopWidget(): Exit
			SPDesktop::SPDesktop: entrance
			Selection::Selection
			SPDesktop::SPDesktop: exit
			SPDesktop::init(): entrance
			Selection::Selection
			SPDesktop::init(): Exit
			SPDesktopWidget::on_realize: Entrance
			SPDesktopWidget::on_realize: Exit
			InkscapeWindow::InkscapeWindow: Exit

			ADD DUPLICATE WINDOW

			InkscapeWindow::InkscapeWindow: Entrance
			SPDesktopWidget::SPDesktopWidget(): Entrance
			SPDesktopWidget::SPDesktopWidget(): Exit
			SPDesktop::SPDesktop: entrance
			Selection::Selection
			SPDesktop::SPDesktop: exit
			SPDesktop::init(): entrance
			SPDesktop::init(): Exit
			SPDesktopWidget::on_realize: Entrance
			SPDesktopWidget::on_realize: Exit
			InkscapeWindow::InkscapeWindow: Exit

			REMOVE DUPLICATE WINDOW
			InkscapeWindow::~InkscapeWindow: Entrance
			InkscapeWindow::~InkscapeWindow: Exit
			SPDesktopWidget::on_unrealize: Entrance
			SPDesktop::destroy()
			Selection::~Selection(): Entrance
			Selection::~Selection(): Exit
			SPDesktop::destroy(): Exit
			SPDesktopWidget::on_unrealize: Exit
			SPDesktopWidget::~SPDesktopWidget
			SPDesktop::~SPDesktop

			REMOVE NEW DOCUMENT WINDOW

			InkscapeWindow::~InkscapeWindow: Entrance
			InkscapeWindow::~InkscapeWindow: Exit
			SPDesktopWidget::on_unrealize: Entrance
			SPDesktop::destroy()
			Selection::~Selection(): Entrance
			Selection::~Selection(): Exit
			SPDesktop::destroy(): Exit
			SPDesktopWidget::on_unrealize: Exit
			SPDesktopWidget::~SPDesktopWidget
			SPDocument::~SPDocument(): Entrance
			SPDocument::~SPDocument(): Exit
			SPDesktop::~SPDesktop

			CLOSE INKSCAPE

			InkscapeWindow::~InkscapeWindow: Entrance
			InkscapeWindow::~InkscapeWindow: Exit
			SPDesktopWidget::on_unrealize: Entrance
			SPDesktop::destroy()
			Selection::~Selection(): Entrance
			Selection::~Selection(): Exit
			SPDesktop::destroy(): Exit
			SPDesktopWidget::on_unrealize: Exit
			SPDesktopWidget::~SPDesktopWidget
			SPDocument::~SPDocument(): Entrance
			SPDocument::~SPDocument(): Exit
			SPDesktop::~SPDesktop


			</pre>Application destructor not called! InkscapeApplication destructor not called!

Tavmjong: /* Desktop */

2021-09-11T14:25:56Z

Desktop

← Older revision		Revision as of 14:25, 11 September 2021
Line 63:		Line 63:
	# New layer pop-up where desktop is needed to add layer (why?).		# New layer pop-up where desktop is needed to add layer (why?).

	~~It's~~ used in these files:		GC is used in these files:
	* live_effects/parameter/powerstrokepointarray.cpp		* live_effects/parameter/powerstrokepointarray.cpp
	* ui/dialog/knot-properties.cpp (only in with Measure Tool). Removed		* ui/dialog/knot-properties.cpp (only in with Measure Tool). Removed
Line 72:		Line 72:
	* src/widgets/desktop-widget.cpp		* src/widgets/desktop-widget.cpp
	* src/ui/view/view.cpp		* src/ui/view/view.cpp
			Floating dialogs should be updated with a new desktop before a desktop is destroyed.

	==== Undo stack ====		==== Undo stack ====

Tavmjong at 15:01, 9 September 2021

2021-09-09T15:01:44Z

← Older revision		Revision as of 15:01, 9 September 2021
Line 57:		Line 57:
	Desktop should be owned by InkscapeWindow. There should be no need to ref count.		Desktop should be owned by InkscapeWindow. There should be no need to ref count.

	The desktop is used in the following sources for ~~two~~ purpose~~, one to find the SPDocument and the second to ensure the pop-up window is over the correct window.~~		The desktop is used in the following sources for these purpose:

			# To find the SPDocument
			# To ensure the pop-up window is over the correct window. As pop-up windows seize control, the desktop cannot disappear from beneath them.
			# New layer pop-up where desktop is needed to add layer (why?).

			It's used in these files:
	* live_effects/parameter/powerstrokepointarray.cpp		* live_effects/parameter/powerstrokepointarray.cpp
	* ui/dialog/knot-properties.cpp		* ui/dialog/knot-properties.cpp (only in with Measure Tool). Removed
	* ui/dialog/layer-properties.cpp		* ui/dialog/layer-properties.cpp. Removed
	* ui/dialog/lpe-fillet-chamfer-properties.cpp		* ui/dialog/lpe-fillet-chamfer-properties.cpp. Removed.
	* ui/dialog/lpe-powerstroke-properties.cpp		* ui/dialog/lpe-powerstroke-properties.cpp. Removed.
	* ui/tools/measure-tool.~~cpp~~		* /ui/widget/style-subject.cpp (used by Fill and Stroke, and Layers dialogs for opacity, blending, and blurring).
	* /ui/widget/style-subject.cpp
	* src/widgets/desktop-widget.cpp		* src/widgets/desktop-widget.cpp
	* src/ui/view/view.cpp		* src/ui/view/view.cpp

Tavmjong: /* Desktop */

2021-09-08T15:41:04Z

Desktop

← Older revision		Revision as of 15:41, 8 September 2021
Line 68:		Line 68:
	* src/widgets/desktop-widget.cpp		* src/widgets/desktop-widget.cpp
	* src/ui/view/view.cpp		* src/ui/view/view.cpp

			==== Undo stack ====
			The undo stack should be owned by the document.

			==== Selections ====
			Selections should be owned by InkscapeWindow with an additional selection owned by InkscapeApplication for use with the GUI.

Tavmjong: /* Document */

2021-09-08T15:37:19Z

Document

← Older revision		Revision as of 15:37, 8 September 2021
Line 53:		Line 53:

	Inkscape::Application (different from InkscapeApplication) has a list of documents too. This list should be removed (as should Inkscape::Application).		Inkscape::Application (different from InkscapeApplication) has a list of documents too. This list should be removed (as should Inkscape::Application).

			==== Desktop ====
			Desktop should be owned by InkscapeWindow. There should be no need to ref count.

			The desktop is used in the following sources for two purpose, one to find the SPDocument and the second to ensure the pop-up window is over the correct window.

			* live_effects/parameter/powerstrokepointarray.cpp
			* ui/dialog/knot-properties.cpp
			* ui/dialog/layer-properties.cpp
			* ui/dialog/lpe-fillet-chamfer-properties.cpp
			* ui/dialog/lpe-powerstroke-properties.cpp
			* ui/tools/measure-tool.cpp
			* /ui/widget/style-subject.cpp
			* src/widgets/desktop-widget.cpp
			* src/ui/view/view.cpp

Tavmjong: /* Document */

2021-09-08T15:28:34Z

Document

← Older revision		Revision as of 15:28, 8 September 2021
Line 51:		Line 51:

	One problem, when saving, a document is copied so it can be modified in place. This document stores a reference to the original document.		One problem, when saving, a document is copied so it can be modified in place. This document stores a reference to the original document.

			Inkscape::Application (different from InkscapeApplication) has a list of documents too. This list should be removed (as should Inkscape::Application).

Tavmjong at 11:44, 6 September 2021

2021-09-06T11:44:30Z

← Older revision		Revision as of 11:44, 6 September 2021
Line 34:		Line 34:
	* Clipboard (ui/clipboard.cpp, uses SPDocument::createNewDoc(), uses std::unique_ptr)		* Clipboard (ui/clipboard.cpp, uses SPDocument::createNewDoc(), uses std::unique_ptr)
	* InkView (inkview-window.h, uses SPDocument::createNewDoc(), not deleted!)		* InkView (inkview-window.h, uses SPDocument::createNewDoc(), not deleted!)
	* ink_file_new(), ink_file_open() (io/file.cpp, uses SPDocument::createNewDoc, not deleted, utility for other functions)		* ink_file_new(), ink_file_open() (io/file.cpp, uses SPDocument::createNewDoc(), not deleted, utility for other functions)
			*CDR (extension/internal/cdr-input.cpp, uses SPDocument::createNewDocFromMem() x3, not deleted!)
			*SVG (extension/internal/svg.cpp, uses SPDocument::createNew() x3, SPDocument::createNewDocFromMem(), not deleted!)
			*PDF Input ...
			*PixBuf
			*WMF
			*WPG
			*Gimp Grad
			*EMF
			*VSD
			*DBUS
			*Cairo utils (display/cairo-utils.cpp, uses SPDocument::createNewDocFromMem(), uses std::unique_ptr)
			*Stock items (helper/stock-items.cpp, uses SPDocument::createNewDoc(), markers, static, not deleted).
			*URIReference (object/uri-reference.cpp, uses SPDocument::createChildDoc(),
	*		*

	One problem, when saving, a document is copied so it can be modified in place. This document stores a reference to the original document.		One problem, when saving, a document is copied so it can be modified in place. This document stores a reference to the original document.

Tavmjong at 08:17, 5 September 2021

2021-09-05T08:17:51Z

← Older revision		Revision as of 08:17, 5 September 2021
Line 14:		Line 14:
	* Selections: selection.h		* Selections: selection.h
	* Document subset: document-subset.h		* Document subset: document-subset.h

			==== Document ====
			Documents opened for editing should be owned by InkscapeApplication.

			* Help (tutorials)

			Temporary documents should be opened with unique_ptr<>.

			* SVG Cursors (ui/cursor-utils.cpp, uses ink_file_open(), unique_ptr)
			* SVG to Pixbuf (ui/svg-renderer.cpp, uses ink_file_open(), unique_ptr)
			* SPDocument::copy (document.cpp, uses createDoc() ***)
			* Paint selector (ui/widget/paint-selector.cpp, uses SPDocument::createNewDoc, static, never deleted)
			* Markers (ui/widget/marker-combo-box.cpp, uses SPDocument::createNewDoc, static, never deleted)
			* Symbols (ui/dialog/symbols.cpp, uses SPDocument::createNewDoc() x3, not clear if any deleted)
			* Win32 File (ui/dialog/filedialogimpl-win32.cpp, uses SPDocument::createNewDoc(), unique_ptr)
			* About (ui/dialog/about.cpp, uses SPDocument::createNewDoc(), document not deleted!)
			* Paint servers (ui/dialog/paint-servers.cpp, uses SPDocument::createNewDoc(), not deleted!)
			* SVG Preview (ui/dialog/svg-preview.cpp, uses SPDocument::createNewDoc(), deleted in destructor)
			* Clipboard (ui/clipboard.cpp, uses SPDocument::createNewDoc(), uses std::unique_ptr)
			* InkView (inkview-window.h, uses SPDocument::createNewDoc(), not deleted!)
			* ink_file_new(), ink_file_open() (io/file.cpp, uses SPDocument::createNewDoc, not deleted, utility for other functions)
			*

			One problem, when saving, a document is copied so it can be modified in place. This document stores a reference to the original document.

Tavmjong: Created page with " Inkscape currently uses garbage collecting to manage the lifetime of many objects. This is problematic... Objects managed by GC: (grep -Ir GC:: src | grep public): * SPD..."

2021-09-05T07:15:10Z

Created page with " Inkscape currently uses garbage collecting to manage the lifetime of many objects. This is problematic... Objects managed by GC: (grep -Ir GC:: src | grep public): * SPD..."

New page

Inkscape currently uses garbage collecting to manage the lifetime of many objects. This is problematic...

Objects managed by GC: (grep -Ir GC:: src | grep public):

* SPDocument: src/document.h
* SPDesktop (via View): ui/view/view.h
* Undo stack: undo-stack-observer.h
* XML nodes: xml/event.h, xml/attribute-record.h, xml/composite-node-observer.h, xml/node.h, xml/simple-node-observer.h, xml/simple-node.h
* Profile manager: profile-manager.h
* Layer manager: layer-manager.h
* Selections: selection.h
* Document subset: document-subset.h