Future Architecture - Revision history

Tavmjong: /* Questions/Comments */

2019-01-24T12:41:54Z

Questions/Comments

← Older revision		Revision as of 12:41, 24 January 2019
Line 78:		Line 78:
	* ui/dialog/desktop-tracker		* ui/dialog/desktop-tracker

	The code in ui/interface should be merged into InkscapeApplication or DocumentWindow or split out into more specific files.		The code in ui/interface should be merged into InkscapeApplication or DocumentWindow or split out into more specific files. IN PROGRESS

Tavmjong: /* Steps */

2019-01-24T12:41:28Z

Steps

← Older revision		Revision as of 12:41, 24 January 2019
Line 54:		Line 54:
	# Move from Gtk::Main::run() to Gtk::Application. DONE		# Move from Gtk::Main::run() to Gtk::Application. DONE
	# Move to Gtk::ApplicationWindow (InkscapeWindow). IN PROGRESS		# Move to Gtk::ApplicationWindow (InkscapeWindow). IN PROGRESS
	# Split the current code in inkscape.cpp between InkscapeApplication (Gtk::Application) and ~~DocumentWindow~~ (Gtk::ApplicationWindow) as appropriate.		# Split the current code in inkscape.cpp between InkscapeApplication (Gtk::Application) and InkscapeWindow (Gtk::ApplicationWindow) as appropriate.
	# Rewrite View to contain selections and not depend on GUI (move signals, message stack elsewhere). STARTED		# Rewrite View to contain selections and not depend on GUI (move signals, message stack elsewhere). STARTED
	# Rewrite SPDesktopWidget: C++ify. Derive from Gtk::Box or embed directly in InksapeWindow. Rename to DesktopViewWidget (to match SVGViewWidget).		# Rewrite SPDesktopWidget: C++ify. Derive from Gtk::Box or embed directly in InksapeWindow. Rename to DesktopViewWidget (to match SVGViewWidget).

Tavmjong: /* Means */

2019-01-24T12:40:29Z

Means

← Older revision		Revision as of 12:40, 24 January 2019
Line 13:		Line 13:
	==Means==		==Means==

	Adopt Gio::Actions which separates GUI from actions. Use standard GTK3 classes. Rely on GTK3 active window tracking functionality.		* Adopt Gio::Actions which separates GUI from actions.
			* Move Inkscape's custom verbs to Gio::Actions.
			* Use standard GTK3 classes.
			* Rely on GTK3 active window tracking functionality.

	==Design==		==Design==

Tavmjong: /* Means */

2019-01-24T12:39:25Z

Means

← Older revision		Revision as of 12:39, 24 January 2019
Line 13:		Line 13:
	==Means==		==Means==

	Adopt Gio::Actions which separates GUI from actions. Use standard GTK3 classes.		Adopt Gio::Actions which separates GUI from actions. Use standard GTK3 classes. Rely on GTK3 active window tracking functionality.

	==Design==		==Design==

Tavmjong: /* Problem */

2019-01-24T12:38:43Z

Problem

← Older revision		Revision as of 12:38, 24 January 2019
Line 7:		Line 7:
	Inkscape's code is very convoluted. In particular the GUI code is		Inkscape's code is very convoluted. In particular the GUI code is
	embeded everywhere. One can't even open an SVG file without		embeded everywhere. One can't even open an SVG file without
	encountering GUI code. Inkscape is also a signalling nightmare.		encountering GUI code (fixed!). Inkscape is also a signalling nightmare.
	It's hard to keep signals correct. Often the same function is called		It's hard to keep signals correct. Often the same function is called
	needlessly multiple times as a result of a simple action.		needlessly multiple times as a result of a simple action.

Tavmjong: /* Design */

2019-01-24T12:37:50Z

Design

← Older revision		Revision as of 12:37, 24 January 2019
Line 26:		Line 26:
	** Keeps a map indexed by document to vectors of windows. A vector is used to update windows in response to document changes.		** Keeps a map indexed by document to vectors of windows. A vector is used to update windows in response to document changes.
	** A vector of windows can be empty (as in the case of a headless Inkscape).		** A vector of windows can be empty (as in the case of a headless Inkscape).
			** Keeps pointers to (updated when focus window changed or new document read-in [headless]):
			*** Current document
			*** Current selection
			*** Current view
	* Windows:		* Windows:
	** There are two types of window:		** There are two types of window:

Tavmjong: /* Steps */

2019-01-24T12:34:44Z

Steps

← Older revision		Revision as of 12:34, 24 January 2019
Line 46:		Line 46:

	# Move from Gtk::Main::run() to Gtk::Application. DONE		# Move from Gtk::Main::run() to Gtk::Application. DONE
	# Move to Gtk::ApplicationWindow		# Move to Gtk::ApplicationWindow (InkscapeWindow). IN PROGRESS
	# Split the current code in inkscape.cpp between InkscapeApplication (Gtk::Application) and DocumentWindow (Gtk::ApplicationWindow) as appropriate.		# Split the current code in inkscape.cpp between InkscapeApplication (Gtk::Application) and DocumentWindow (Gtk::ApplicationWindow) as appropriate.
	# Rewrite View to contain selections and not depend on GUI (move signals, message stack elsewhere). STARTED		# Rewrite View to contain selections and not depend on GUI (move signals, message stack elsewhere). STARTED
	# Rewrite SPDesktopWidget: C++ify. Derive from Gtk::Box. Rename to DesktopViewWidget (to match SVGViewWidget).		# Rewrite SPDesktopWidget: C++ify. Derive from Gtk::Box or embed directly in InksapeWindow. Rename to DesktopViewWidget (to match SVGViewWidget).
	# Replace our desktop switching signals/codes with code based on Gtk::Application's "active" window tracking ability.		# Replace our desktop switching signals/codes with code based on Gtk::Application's "active" window tracking ability.
	# Use Gio::Actions STARTED		# Use Gio::Actions STARTED

Tavmjong: /* Design */

2019-01-10T19:04:47Z

Design

← Older revision		Revision as of 19:04, 10 January 2019
Line 24:		Line 24:
	*** An independent transform. (Canvas to document transform if a canvas is present, identity matrix if not.)		*** An independent transform. (Canvas to document transform if a canvas is present, identity matrix if not.)
	* Application:		* Application:
	** Keeps a map indexed by document to ~~a list~~ of windows. ~~This list~~ is used to update windows in response to document changes.		** Keeps a map indexed by document to vectors of windows. A vector is used to update windows in response to document changes.
			** A vector of windows can be empty (as in the case of a headless Inkscape).
	* Windows:		* Windows:
	** There are two types of window:		** There are two types of window:

Tavmjong: /* Design */

2019-01-10T19:02:42Z

Design

← Older revision		Revision as of 19:02, 10 January 2019
Line 23:		Line 23:
	*** An independent selection.		*** An independent selection.
	*** An independent transform. (Canvas to document transform if a canvas is present, identity matrix if not.)		*** An independent transform. (Canvas to document transform if a canvas is present, identity matrix if not.)
			* Application:
			** Keeps a map indexed by document to a list of windows. This list is used to update windows in response to document changes.
	* Windows:		* Windows:
	** There are two types of window:		** There are two types of window:

Tavmjong: /* Steps */

2018-11-29T14:45:13Z

Steps

← Older revision		Revision as of 14:45, 29 November 2018
Line 45:		Line 45:
	# Move to Gtk::ApplicationWindow		# Move to Gtk::ApplicationWindow
	# Split the current code in inkscape.cpp between InkscapeApplication (Gtk::Application) and DocumentWindow (Gtk::ApplicationWindow) as appropriate.		# Split the current code in inkscape.cpp between InkscapeApplication (Gtk::Application) and DocumentWindow (Gtk::ApplicationWindow) as appropriate.
	~~# Start adding actions. DONE~~		# Rewrite View to contain selections and not depend on GUI (move signals, message stack elsewhere). STARTED
	~~# Use actions in Command Line and GUI. STARTED~~
	# Rewrite View to contain selections and not depend on GUI (move signals, message stack elsewhere).
	# Rewrite SPDesktopWidget: C++ify. Derive from Gtk::Box. Rename to DesktopViewWidget (to match SVGViewWidget).		# Rewrite SPDesktopWidget: C++ify. Derive from Gtk::Box. Rename to DesktopViewWidget (to match SVGViewWidget).
			# Replace our desktop switching signals/codes with code based on Gtk::Application's "active" window tracking ability.
			# Use Gio::Actions STARTED
			#* Replace Verbs (mostly tied to desktop) by GUI independent actions.
			#* Use actions in Command Line. MOSTLY DONE
			#* Use actions in GUI (e.g. replace our custom GtkAction subclasses in Toolbars, replace custom widget classes).

	==Questions/Comments==		==Questions/Comments==